-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly verify the publickey signing #1
Conversation
Signed-off-by: Andrew Thornton <art27@cantab.net>
I'm testing with your changes and I'm getting Fixed by using |
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Just tested your changes, works fine with certificate and pub/priv key |
OK I think that's it. The original code wasn't actually verifying that public key we'd found actually signed the request. |
Yes, I was a bit too fast there. |
no problem I hope you don't mind the pr to your pr |
No of course not 👍 |
Signed-off-by: Andrew Thornton art27@cantab.net